Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused ingestion deps #520

Merged
merged 2 commits into from
Mar 9, 2020
Merged

Remove unused ingestion deps #520

merged 2 commits into from
Mar 9, 2020

Conversation

ches
Copy link
Member

@ches ches commented Mar 8, 2020

What this PR does / why we need it:

Remove unused deps from Ingestion module, for the usual reasons of Good Housekeeping.

My path to this:

Which issue(s) this PR fixes:

None

Does this PR introduce a user-facing change?:

NONE

ches added 2 commits March 8, 2020 13:33
@ches
Make dependency:analyze run clean on datatypes-java
f4e01a2
@ches
Remove stale dependencies from ingestion
7e5eb29 
Unused according to `mvn -pl ingestion dependency:analyze`, and tests.

We had a recent bump of hibernate-validator with a CVE fix (feast-dev#421) that I
was looking to backport, and it turns out it's not used anymore anyway.
@ches ches added kind/housekeeping area/ingestion The ingestion Beam component and storage-related items labels Mar 8, 2020
@ches
Copy link
Member Author

ches commented Mar 8, 2020

/assign @thirteen37

@ches
Copy link
Member Author

ches commented Mar 8, 2020

Not sure yet whether this is flaky or a legitimate failure, but the failure mode of this test could stand to improve:

bq-batch-retrieval.py:201: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

.0 = <list_iterator object at 0x7f528fc18c10>

>   assert output["entity_id"].to_list() == [int(i) for i in output["feature_value2"].to_list()]
E   TypeError: int() argument must be a string, a bytes-like object or a number, not 'NoneType'

bq-batch-retrieval.py:201: TypeError

I'll see if I can find a quick way to do that.

@ches
Copy link
Member Author

ches commented Mar 8, 2020

/test test-end-to-end-batch

@ches ches added the backport-candidate Changes that may be desired for backport to earlier Feast release tracks label Mar 8, 2020
@ches ches mentioned this pull request Mar 8, 2020
Merged
@woop
Copy link
Member

woop commented Mar 9, 2020

Thanks for this "housekeeping" pull @ches

Not sure yet whether this is flaky or a legitimate failure, but the failure mode of this test could stand to improve:

Our tests still have a lot of debt as you pointed out elsewhere.

Happy to merge this in.

@woop
Copy link
Member

woop commented Mar 9, 2020

/lgtm
/approve

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ches, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit b15a5e6 into feast-dev:master Mar 9, 2020
@ches ches deleted the remove-unused-ingestion-deps branch March 9, 2020 04:32
@ches
Copy link
Member Author

ches commented Mar 9, 2020

Our tests still have a lot of debt as you pointed out elsewhere.

We're getting to the point of running some e2e tests on our infra—sans Prow and sans Google Cloud-dependent tests—so hopefully we can pitch in to ones that bite us.

khorshuheng pushed a commit to khorshuheng/feast that referenced this pull request Mar 16, 2020
@ches @khorshuheng
Remove unused ingestion deps (feast-dev#520)
346218c 
* Make dependency:analyze run clean on datatypes-java

* Remove stale dependencies from ingestion

Unused according to `mvn -pl ingestion dependency:analyze`, and tests.

We had a recent bump of hibernate-validator with a CVE fix (feast-dev#421) that I
was looking to backport, and it turns out it's not used anymore anyway.
@khorshuheng khorshuheng mentioned this pull request Mar 16, 2020
Merged
khorshuheng pushed a commit that referenced this pull request Mar 16, 2020
@ches @khorshuheng
Remove unused ingestion deps (#520)
7aab77d 
* Make dependency:analyze run clean on datatypes-java

* Remove stale dependencies from ingestion

Unused according to `mvn -pl ingestion dependency:analyze`, and tests.

We had a recent bump of hibernate-validator with a CVE fix (#421) that I
was looking to backport, and it turns out it's not used anymore anyway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidheryanto davidheryanto Awaiting requested review from davidheryanto

@khorshuheng khorshuheng Awaiting requested review from khorshuheng

@pradithya pradithya Awaiting requested review from pradithya

@woop woop Awaiting requested review from woop

@zhilingc zhilingc Awaiting requested review from zhilingc

Assignees

@thirteen37 thirteen37

@woop woop

Labels
approved area/ingestion The ingestion Beam component and storage-related items backport-candidate Changes that may be desired for backport to earlier Feast release tracks kind/housekeeping lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ches @woop @feast-ci-bot @thirteen37